Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test dependencies #5609

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Apr 5, 2023

Summary

This PR upgrades packages used only by tests

@bdukes bdukes added this to the 9.11.3 milestone Apr 5, 2023
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - accidentally approved. I meant to comment about the failed build.

@bdukes
Copy link
Contributor Author

bdukes commented Apr 5, 2023

Hmmm… that happened locally, it's missing an assembly from the output directory (even though it's marked as Copy Local). I had thought maybe it was an environment thing and we wouldn't see it in a clean CI build, but I guess not… It's only that one Config console tests project. I didn't see an obvious difference.

@bdukes
Copy link
Contributor Author

bdukes commented Apr 6, 2023

@david-poindexter removing the reference to the assembly it needed resolved the issue 🤷🏻‍♂️

@bdukes bdukes requested a review from david-poindexter April 6, 2023 14:15
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bdukes 🎉

@david-poindexter david-poindexter merged commit 1496fc6 into dnnsoftware:develop Apr 7, 2023
@david-poindexter david-poindexter deleted the upgrade-tests branch April 7, 2023 05:36
@valadas valadas changed the title Update test dependencies Updated test dependencies Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants