Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue that prevented uploading images using the HTML Editor #5656

Conversation

skamphuis
Copy link
Contributor

This PR contains a fix for #5645.

The previous fix for drag/drop of images (#5415 ) broke the upload via the dialog. This fix makes sure both uploads are working as expected.

The upload-request coming from Drag/drop contains a querystring variable "responseType" which I'm using here to determine which response to send.

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdukes bdukes added this to the 9.12.0 milestone Jun 12, 2023
…ser/Browser.aspx.cs

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skamphuis 🎉

@david-poindexter david-poindexter merged commit 998d052 into dnnsoftware:develop Jun 13, 2023
@valadas valadas changed the title Fixes #5645 image upload problem Fixed an issue that prevented uploading images using the HTML Editor Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants