Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PersonaBar Manage/Roles to show Role ID #6154

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Update PersonaBar Manage/Roles to show Role ID #6154

merged 2 commits into from
Oct 5, 2024

Conversation

jeremy-farrance
Copy link
Contributor

Fixes Issue #6153

[Enhancement]: PersonaBar, Manage Roles - Add Role ID to Visible Information

This screenshot shows the result of these changes.
image

valadas
valadas reviewed Oct 5, 2024
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but:

  1. Could it maybe not be bolder than the reset, it stands out a bit much IMO.
  2. The added props already existed but were not typed I guess, so it fixes warnings ?

@valadas valadas mentioned this pull request Oct 5, 2024
Merged
@jeremy-farrance
Update index.jsx
b940385 
Removed bolder from label.
@jeremy-farrance
Copy link
Contributor Author

Looks good but:

  1. Could it maybe not be bolder than the reset, it stands out a bit much IMO.
  2. The added props already existed but were not typed I guess, so it fixes warnings ?

Agree on 1, updated/removed bolder from the label. For 2, yes, left them in because it was nice to see it compile with no warnings! :)

valadas
valadas approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick turnaround

david-poindexter
david-poindexter approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you @jeremy-farrance 🎉

@david-poindexter david-poindexter added this to the 9.13.5 milestone Oct 5, 2024
@david-poindexter david-poindexter merged commit 87cbd77 into dnnsoftware:develop Oct 5, 2024
3 checks passed
@david-poindexter david-poindexter mentioned this pull request Oct 5, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees
No one assigned
Labels
Area: AE > PersonaBar Ext > Roles.Web Effort: Low Priority: Low Status: Review Type: Enhancement
Projects
None yet
Milestone
9.13.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremy-farrance @david-poindexter @valadas