Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GitVersion config less ambiguous #6195

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Nov 5, 2024

Summary

Some of our builds have failed due to Cake being unable to parse the GitVersion output. Running locally with Diagnostic verbosity, I receive the following error message at the top of the output:

Multiple branch configurations match the current branch branchName of 'bdukes/merge-develop-to-release-10.0.0'. Using the first matching configuration, 'develop'. Matching configurations include:'
 - develop
 - release'

I've deleted any branches that I can see with both develop and release in the name for the short-term.

This PR updates the regex field for the branches to include ^ (starts with) and $ (ends with) tokens, so that the match is exact (i.e. the develop rule only matches the develop branch, not other branches that have develop in the name).

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks @bdukes

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@valadas valadas merged commit 020547c into dnnsoftware:develop Nov 6, 2024
3 checks passed
@bdukes bdukes deleted the fix-gitversion branch November 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants