Fix server info error on .NET 4.8 #6201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
Nov 7, 2024
|
@bdukes looks like one test is failing here:
|
bdukes
commented
Nov 7, 2024
DNN Platform/Tests/DotNetNuke.Tests.Core/Common/GlobalsTests.cs
Outdated
Show resolved
Hide resolved
🤦🏻♂️ thanks, fix pushed |
|
@bdukes Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Versiononly has two parts (e.g.new Version("4.8")), it throws an exception when calling.ToString(3). This PR adds astringFormattedNetFrameworkVersionproperty toGlobals(to complementVersion Globals.NETFrameworkVersion) and replaces all usages ofGlobals.NETFrameworkVersion.ToStringwithGlobals.FormattedNetFrameworkVersion. This property usesGlobals.FormatVersionto do the formatting, which has logic to replace a-1from a two-digit version with a0to make a three-digit version.I also added a few tests for
Globals.FormatVersionto verify its behavior and documented that only the verbose overload has that logic and thatGlobals.FormatVersion(new Version("4.8"))will output"04.00.-01".Fixes #6200