Updated Quick Settings Performance #6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes dnnsoftware#6241 Given the reported issue in dnnsoftware#6239, each time a module setting is updated the cache is cleared. The current code, was always updating the first load to be false, even if the first load value was already set to false. This change utilizes the retreived setting value to ensure that we are ONLY updateing the module to flip the quick settings flag to false if it is currently set to true. This has a substantial impact to performance for modules using Quick Settings.
bdukes
approved these changes
Dec 6, 2024
|
That's great, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the reported issue in #6239, each time a module setting is updated the cache is cleared. The current code, was always updating the first load to be false, even if the first load value was already set to false.
This change utilizes the retreived setting value to ensure that we are ONLY updateing the module to flip the quick settings flag to false if it is currently set to true. This has a substantial impact to performance for modules using Quick Settings.