Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More RDATA types that need label decompression #12

Open
banburybill opened this issue Jan 30, 2018 · 0 comments
Open

More RDATA types that need label decompression #12

banburybill opened this issue Jan 30, 2018 · 0 comments

Comments

@banburybill
Copy link
Contributor

In the compactor we current expand compressed names in NS, CNAME, PTR, MX and SOA RRs.

Looking at the discussion I've just found in https://tools.ietf.org/html/rfc3597 in section 4, we're handling all the MUST RR types but we SHOULD also expand RP, AFSDB, RT, SIG, PX, NXT, NAPTR, and SRV.
banburybill pushed a commit that referenced this issue Jan 31, 2018
Ensure name in SRV record is expanded, per RFC3597.
0aa1d5e 
Very much a just in case, as name compression in SRV is no longer permitted. But play it safe. #12.

While there, add some tests checking expansion in MX and SRV.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@banburybill