Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for key-data interface creating delegation signer record #29

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Add support for key-data interface creating delegation signer record #29

merged 5 commits into from
Oct 6, 2021

Conversation

jacegu
Copy link
Contributor

@jacegu jacegu commented Oct 6, 2021

This PR:

  • Updates the fixtures from dnsimple-developer repo to reflect the latest changes to our DNSSEC-related APIs.
  • Adds new fields to affected structs.

I was able to verify the changes by enabling DNSSEC on one of our testing .BE domains.

@jacegu jacegu self-assigned this Oct 6, 2021
@jacegu jacegu marked this pull request as ready for review October 6, 2021 12:21
@jacegu jacegu requested review from a team, OleMchls and dallasread and removed request for a team October 6, 2021 12:21
dallasread
dallasread approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@dallasread dallasread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ This looks good to me – thanks!

@jacegu jacegu merged commit 9c8b923 into main Oct 6, 2021
@jacegu jacegu deleted the dnssec-key-data-support branch October 6, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallasread dallasread dallasread approved these changes

@OleMchls OleMchls OleMchls approved these changes

Assignees

@jacegu jacegu

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacegu @OleMchls @dallasread