Skip to content

Commit

Permalink
Patch cycle - 2024 / Cycle 5 (#455)
Browse files Browse the repository at this point in the history
  • Loading branch information
dallasread authored Dec 12, 2024
1 parent 0a3e221 commit 13fe5d5
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
matrix:
python-version:
- '3.12'
- '3.13'
steps:
- uses: actions/checkout@v4
- name: Set up Python
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@
*.egg-info

/poetry.lock

.tool-versions
1 change: 0 additions & 1 deletion .tool-versions

This file was deleted.

2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
- NEW: Added `alias_email` and `destination_email` to `EmailForward`
- CHANGED: Deprecated `email_from` and `email_to` fields in `EmailForward`
- CHANGED: Aligned `EmailForwardInput` constructor param names with current endpoint definition
- CHANGED: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.
- NEW: Add support for python 3.13

## 3.0.0

Expand Down
4 changes: 2 additions & 2 deletions LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2022 DNSimple Corporation
Copyright (c) 2024 DNSimple Corporation

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
SOFTWARE.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ A Python client for the [DNSimple API v2](https://developer.dnsimple.com/v2/).

## Requirements

- Python 3.12 - Note later versions of Python may be supported, but we make no guarantees as they are not tracked in our CI.
- Python 3.12+ - Note later versions of Python may be supported, but we make no guarantees as they are not tracked in our CI.

## Installation

Expand Down Expand Up @@ -143,4 +143,4 @@ Contibutions are welcomed. Please open an issue to discuss the changes before op

## License

Copyright (c) 2022 DNSimple Corporation. This is Free Software distributed under the MIT license.
Copyright (c) 2024 DNSimple Corporation. This is Free Software distributed under the MIT license.
4 changes: 4 additions & 0 deletions dnsimple/service/domains.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json
import warnings

from dnsimple.response import Response
from dnsimple.struct import Domain, Dnssec, Collaborator, DelegationSignerRecord, EmailForward, DomainPush
Expand Down Expand Up @@ -111,6 +112,7 @@ def list_collaborators(self, account_id, domain):
:return: dnsimple.Response
A list of collaborators for the domain in the account
"""
warnings.warn("DEPRECATION WARNING: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.")
response = self.client.get(f'/{account_id}/domains/{domain}/collaborators')
return Response(response, Collaborator)

Expand Down Expand Up @@ -138,6 +140,7 @@ def add_collaborator(self, account_id, domain, email):
:return: dnsimple.Response
The collaborator added to the domain in the account
"""
warnings.warn("DEPRECATION WARNING: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.")
response = self.client.post(f'/{account_id}/domains/{domain}/collaborators', data=json.dumps({'email': email}))
return Response(response, Collaborator)

Expand All @@ -157,6 +160,7 @@ def remove_collaborator(self, account_id, domain, collaborator):
:return: dnsimple.Response
An empty response
"""
warnings.warn("DEPRECATION WARNING: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.")
response = self.client.delete(f'/{account_id}/domains/{domain}/collaborators/{collaborator}')
return Response(response)

Expand Down

0 comments on commit 13fe5d5

Please sign in to comment.