This repository has been archived by the owner on May 26, 2024. It is now read-only.
determineBolusEventType #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnzxy
pushed a commit
that referenced
this pull request
Nov 19, 2023
Add color gradient for dark scheme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the nightscoutTreatmentsNotUploaded() function in the BasePumpHistoryStorage class. Specifically, it isolates the logic for determining the EventType for bolus events into a separate helper function named determineBolusEventType().
Motivation
The change aims to improve code maintainability and readability. Previously, the logic for determining the EventType for bolus events was embedded within the nightscoutTreatmentsNotUploaded() function. This led to a longer and more complex function, making it harder to understand and maintain.
Implementation Details
A new function, determineBolusEventType(for:), has been introduced. This function takes a PumpHistoryEvent as an argument and returns an EventType. The logic for determining the EventType has been moved from nightscoutTreatmentsNotUploaded() to this new function.
The line that previously determined the EventType within nightscoutTreatmentsNotUploaded() has been replaced by a call to determineBolusEventType(for:).
Expected Behavior
The behavior of the code should remain the same. This is a purely structural change aimed at improving code quality.