Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind Breaking Change @ 1.6.0 #19

Closed
kevcjones-archived opened this issue Jul 29, 2020 · 4 comments · Fixed by #20
Closed

Tailwind Breaking Change @ 1.6.0 #19

kevcjones-archived opened this issue Jul 29, 2020 · 4 comments · Fixed by #20

Comments

@kevcjones-archived
Copy link

I've a got a build issue because of some new animation corePlugin vars that are not formed correctly.

$keyframes-spin-from-transform: rotate(0deg);
$keyframes-spin-to-transform: rotate(360deg);
$keyframes-ping-0%-transform: scale(1);
$keyframes-ping-0%-opacity: 1;
$keyframes-ping-75%, 100%-transform: scale(2);
$keyframes-ping-75%, 100%-opacity: 0;
$keyframes-pulse-0%, 100%-opacity: 1;
$keyframes-pulse-50%-opacity: .5;
$keyframes-bounce-0%, 100%-transform: translateY(-25%);
$keyframes-bounce-0%, 100%-animationTimingFunction: (cubic-bezier(0.8,0,1,1));
$keyframes-bounce-50%-transform: translateY(0);
$keyframes-bounce-50%-animationTimingFunction: (cubic-bezier(0,0,0.2,1));

I've tried to block the animation coreplugin but it doesn't see to be respecting the configuration, unless i've doing that wrong.

Any immediate suggestions?

@dobromir-hristov
Copy link
Owner

I have not tried it yet, sorry. I need to see how the JavaScript object looks like before conversion

@kevcjones-archived
Copy link
Author

kevcjones-archived commented Jul 29, 2020

No worries, I've forked for the moment - I think i can stick a custom package in place with 1.5.2 tailwindcss in it to prevent the issue. It's a temp solution.

@kevcjones-archived
Copy link
Author

Not having much joy with that plan actually - i think i know why... I need to publish it so your build scripts work ... src level ain't gonna cut it :D - before i do this - do you have a timeline for when you think you'll be able to look into?

@dobromir-hristov
Copy link
Owner

Try #20, should work for you. 1.6 broke allot of tests, so I cant finish it now, but this should fix your immediate problems.

dobromir-hristov added a commit that referenced this issue Aug 4, 2020
* fix: improve the key sanitization, needed for v TW 1.6 animation keyframes.

* chore: update deps

* chore: reduce test noise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants