Skip to content

Commit

Permalink
e2e: restore volume lifecycle checks for csi-hostpath driver
Browse files Browse the repository at this point in the history
These tests were previously disabled to work around kubernetes#79980
kubernetes@f1e1f3a
  • Loading branch information
dobsonj committed Oct 25, 2022
1 parent 4edf677 commit 589223b
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions test/e2e/storage/drivers/csi.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import (
"encoding/json"
"errors"
"fmt"
"regexp"
"strconv"
"strings"
"sync"
Expand Down Expand Up @@ -245,14 +244,6 @@ func (h *hostpathCSIDriver) PrepareTest(f *framework.Framework) (*storageframewo
NodeName: node.Name,
}

// Disable volume lifecycle checks due to issue #103651 for the one
// test that it breaks.
// TODO: enable this check once issue is resolved for csi-host-path driver
// (https://github.com/kubernetes/kubernetes/pull/104858).
if regexp.MustCompile("should unmount if pod is.*deleted while kubelet is down").MatchString(ginkgo.CurrentGinkgoTestDescription().FullTestText) {
o.DriverContainerArguments = append(o.DriverContainerArguments, "--check-volume-lifecycle=false")
}

cleanup, err := utils.CreateFromManifests(config.Framework, driverNamespace, func(item interface{}) error {
if err := utils.PatchCSIDeployment(config.Framework, o, item); err != nil {
return err
Expand Down

0 comments on commit 589223b

Please sign in to comment.