finalize feature/minMaxAge #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasalvessantos
suggested changes
Feb 19, 2020
| @@ -3,8 +3,24 @@ import utils from "../utils/utils"; | |||
| export default (name, {value, condition, age}) => { | |||
There was a problem hiding this comment.
Nesse arquivo aqui em cima tem uma importação não necessária
validations/age.js
Outdated
| const birthDate = new Date(value); | ||
| const today = new Date(); | ||
| const localAge = today.getFullYear() - birthDate.getFullYear(); | ||
| const month = today.getMonth() - birthDate.getMonth(); |
There was a problem hiding this comment.
Essa variável não está sendo usada
tests/validations/age.spec.js
Outdated
| @@ -1,13 +1,139 @@ | |||
| import validator from '../../index.js' | |||
|
|
|||
| const now = (value) =>{ | |||
| let today = new Date() | |||
validations/age.js
Outdated
| @@ -3,8 +3,24 @@ import utils from "../utils/utils"; | |||
| export default (name, {value, condition, age}) => { | |||
| let field = { | |||
validations/age.js
Outdated
|
|
||
| const birthDate = new Date(value); | ||
| const today = new Date(); | ||
| const localAge = today.getFullYear() - birthDate.getFullYear(); |
There was a problem hiding this comment.
Existe um erro matemático nessa linha, amanhã podemos conversar disso
validations/age.js
Outdated
| } | ||
| // '===', '>=', '<=', '<', '>', '!==' | ||
|
|
||
| const birthDate = new Date(value); |
There was a problem hiding this comment.
Nome dessas variáveis não está semântico
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.