Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Conversation

@kencochrane
Copy link
Contributor

This change is part of a larger PR on docker engine that will remove email from login, and remove the ability to register from the docker cli.

Related PR: moby/moby#20565

Signed-off-by: Ken Cochrane KenCochrane@gmail.com

This change is part of a larger PR on docker engine that will remove email from login, and remove the ability to register from the docker cli.

Signed-off-by: Ken Cochrane <KenCochrane@gmail.com>
@kencochrane kencochrane force-pushed the remove_email_auth_config branch from f18adcb to 9a9e468 Compare February 21, 2016 23:43
@vdemeester
Copy link
Contributor

LGTM 🐰
/ping @calavera

@calavera
Copy link
Contributor

this makes me very happy! 🎉

LGTM

calavera added a commit that referenced this pull request Feb 22, 2016
@calavera calavera merged commit ef288ea into docker-archive-public:master Feb 22, 2016
@runcom
Copy link
Contributor

runcom commented Feb 26, 2016

this is breaking go get for ppl using docker and engine-api though since docker still use Email (but this isn't vendored)

@kencochrane
Copy link
Contributor Author

@runcom I think @dmcgowan is going to add it back in, with an omitempty flag, to fix backwards compatibility issues and such.

@runcom
Copy link
Contributor

runcom commented Feb 26, 2016

@kencochrane alright, that's correct

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants