This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Do not resolve mount linux abs path as windows path on windows #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…var/run/docker.sock => c:/var/run/docker.sock folder) Signed-off-by: guillaume.tardif <guillaume.tardif@gmail.com>
gtardif
force-pushed
the
fix_win_mount_socket
branch
from
fda2ba4 to
7a25378
Compare
ndeloof
approved these changes
May 24, 2021
|
ok, so golang's standard library just does it wrong, nice to know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(eg. /var/run/docker.sock => c:/var/run/docker.sock folder)
What I did
test win mount path with
filepath.IsAbs()and also `HasPrefix("/") for linux abs path...Related issue
Fixes #1591
(not mandatory) A picture of a cute animal, if possible in relation with what you did