This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Print services in dependency order #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `compose config --services` outputs the services in a random/non-deterministic order. In Compose v1, this was implicitly topologically sorted because the project services were pre-sorted. With `compose-go`, the services are unordered, and the `WithServices()` helper can be used to iterate in dependency order. Signed-off-by: Milas Bowman <milasb@gmail.com>
ndeloof
approved these changes
Jul 22, 2021
|
Thanks for the quick turnaround! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Currently,
compose config --servicesoutputs the services ina random/non-deterministic order.
In Compose v1, this was implicitly topologically sorted because
the project services were pre-sorted. With
compose-go, theservices are unordered, and the
WithServices()helper can beused to iterate in dependency order.
Tests
There wasn't a great way to unit test this without further refactoring
as
runServicesusesconvertOptions::toProject()which willattempt to load a real Compose file. (AFAICT there aren't really any
existing CLI unit tests.)
If desirable, I can split the function in two so that the project
conversion from opts is separate from the actual logic which can
just take a
*types.Projectand so would be trivially testable.(not mandatory) A picture of a cute animal, if possible in relation with what you did
