This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
publish cross platform artifacts for PRs #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
pr-binaries
branch
5 times, most recently
from
b2cc2ff
to
817c9ee
Compare
ndeloof
force-pushed
the
pr-binaries
branch
3 times, most recently
from
100b6ec
to
b912b9d
Compare
ulyssessouza
suggested changes
Aug 25, 2021
ndeloof
force-pushed
the
pr-binaries
branch
5 times, most recently
from
79551d3
to
46d3150
Compare
|
@ulyssessouza makes sense. |
ndeloof
force-pushed
the
pr-binaries
branch
2 times, most recently
from
a0b8154
to
93d0bc0
Compare
|
Added an extra step to update the PR comment with a link to workflow run page, so that user can access built binaries |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Co-authored-by: Mathieu Champlon <mathieu.champlon@docker.com> Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Build cross platform binaries and publish artifacts as part of PR builds to make it easier testing changes