Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

metrics: fix unexpected usage output shown on cli #2149

Merged
merged 1 commit into from
May 23, 2022

Conversation

crazy-max
Copy link
Contributor

What I did

Got a hard time to pinpoint this issue but finally found it comes from the cli proxy while parsing args with pflags for build metrics:

$ docker buildx inspect --help

Usage:  docker buildx inspect [NAME]

Inspect current builder instance

Options:
      --bootstrap        Ensure builder has booted before inspecting
      --builder string   Override the configured builder instance
Usage of buildx:
      --builder string

Now with flag set usage silenced:

$ docker buildx inspect --help

Usage:  docker buildx inspect [NAME]

Inspect current builder instance

Options:
      --bootstrap        Ensure builder has booted before inspecting
      --builder string   Override the configured builder instance

cc @tonistiigi

Related issue

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max
Copy link
Contributor Author

Ok to merge this one @glours @mat007 @gtardif?

@glours glours merged commit 415b410 into docker-archive:main May 23, 2022
@crazy-max crazy-max deleted the fix-buildx branch May 23, 2022 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants