This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Add update command for backward compatibility #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-crone
approved these changes
Oct 28, 2020
cli/cmd/context/update.go
Outdated
| package context | ||
|
|
||
| import ( | ||
| "github.com/docker/compose-cli/errdefs" |
cli/cmd/context/update.go
Outdated
| dockerContext, err := s.Get(name) | ||
| if err == nil && dockerContext != nil { | ||
| if dockerContext.Type() != store.DefaultContextType { | ||
| return errors.Wrap(errdefs.ErrNotImplemented, "context update not implemented for context type "+dockerContext.Type()) |
There was a problem hiding this comment.
nit: The current error will stutter with "context update not implemented for context type: not implemented"
Suggested change
| return errors.Wrap(errdefs.ErrNotImplemented, "context update not implemented for context type "+dockerContext.Type()) | |
| return errors.Wrapf(errdefs.ErrNotImplemented, "context update for context type %q not supported", dockerContext.Type()) |
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
gtardif
force-pushed
the
fix_context_update
branch
from
e6c6acd to
0250140
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Tardif guillaume.tardif@docker.com
What I did
context updateanymoreRelated issue
#811
(not mandatory) A picture of a cute animal, if possible in relation with what you did
