Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Improve Vagrant plugin's logging #375

Merged
merged 2 commits into from
Feb 1, 2017

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Feb 1, 2017

This PR makes the vagrant plugin's stderr/stdout streamable to the logging output. This improves the overall usability of the plugin since there won't be a long delay when the code is trying to buffer up the entire command's output. It is now possible to watch in the console what vagrant is actually doing.

Signed-off-by: David Chung david.chung@docker.com

…command

Signed-off-by: David Chung <david.chung@docker.com>
@chungers chungers added this to the v0.3 milestone Feb 1, 2017
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "stream-vagrant-output" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353674872
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers merged commit c9b8799 into docker-archive:master Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants