Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Terraform plugin and Logical IDs allocation #392

Merged
merged 2 commits into from
Feb 11, 2017

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Feb 10, 2017

Fixes #391

  • correctly set the LogicalID tag
  • fixes the terraformLogicalID function

Tests are passing successfully.

Signed-off-by: Nicolas Degory <ndegory@axway.com>
Signed-off-by: Nicolas Degory <ndegory@axway.com>
@codecov-io
Copy link

Codecov Report

Merging #392 into master will increase coverage by <.01%.

@@            Coverage Diff            @@
##           master    #392      +/-   ##
=========================================
+ Coverage   62.49%   62.5%   +<.01%     
=========================================
  Files          56      56              
  Lines        3133    3136       +3     
=========================================
+ Hits         1958    1960       +2     
- Misses        946     947       +1     
  Partials      229     229
Impacted Files Coverage Δ
examples/instance/terraform/plugin.go 51.16% <80%> (+0.49%)
pkg/manager/manager.go 63.03% <ø> (-0.61%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b919e4f...388e9ae. Read the comment docs.

@chungers chungers merged commit 913d307 into docker-archive:master Feb 11, 2017
@chungers chungers added this to the v0.4 milestone Feb 12, 2017
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
* fixes docker-archive#332

Signed-off-by: Nicola Kabar <nicolaka@gmail.com>

* adding DTR to DDC fixes docker-archive#332

Signed-off-by: Nicola Kabar <nicolaka@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogicalIDs allocation fails with Terraform plugin
3 participants