This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the inclusion of libvirt in the core binary optional.
To build with libvirt enabled:
This will include libvirt. libvirt go binding used here isn't a pure Go binding so many users have run into problems with building locally. Cross compilation and linking statically of
infrakit
with libvirt will be fixed in a future PR. Currently there are some problems with-extldflags '-static'
when cross compiling libvirt inside a container.Signed-off-by: David Chung david.chung@docker.com