[18.02] Create 18.02 Changelog #394

jose-bigio · 2018-01-24T00:55:33Z

Everything in the deleted section is what I would intend to delete, but I have left it there for review.
~~Currently going through the triage section to sort it out.~~

Ready for review

Signed-off-by: jose-bigio jose.bigio@docker.com

andrewhsu · 2018-01-24T17:22:47Z

CHANGELOG.md

+https://docs.docker.com/engine/deprecated/ where target removal dates can also
+be found.
+
+## 18.02.0-ce (2017-MM-DD)


replace MM with 02

and 2017 with 2018

mdlinville · 2018-01-24T18:39:18Z

CHANGELOG.md

@@ -1 +1,107 @@
 # Changelog
+
+Items starting with `DEPRECATE` are important deprecation notices. For more
+information on the list of deprecated flags and APIs please have a look at


Let's finally lose the "please" from here and from the template you're using.

Also change the last part to "where you can find target removal dates."

mdlinville · 2018-01-24T18:40:54Z

CHANGELOG.md

+
+## 18.02.0-ce (2018-02-DD)
+
+### ---Triage---


What is this heading?

Victor Vieux created a tool that helps create the changelog.

The triage label is added because the tool itself doesn't categorize every change. I'm still working through categorizing most of the objects in triage, so what will be left is hopefully a small list of changes that I'm unsure about with regards to where they fit in.

To be clear, I am still in the process of preparing the changelog before it is ready for review. Sorry for the confusion. I'll be sure to let you know when I am done.

mdlinville · 2018-01-24T18:41:14Z

CHANGELOG.md

+- Fix timeout issue of  multi-services creation on AArch64 [moby/moby#35998](https://github.com/moby/moby/pull/35998)
+* Improve swagger schema for code generation [moby/moby#35593](https://github.com/moby/moby/pull/35593)
+
+### Delete


What's this?

The delete section is intended to be a temporary field.
Basically it reflects everything I would intend to delete. Having a delete field helps to ensure that I don't delete something that would be important to include in the changelog.

jose-bigio · 2018-01-24T19:04:38Z

@mistyhacks this pull request is more complete now.
I think mainly I need to include the vendoring changes (the specific changes that vendoring bring in)

moby/moby#35976
moby/moby#35748

mdlinville

Left one more nit. LGTM after you manage the Triage and Delete sections.

mdlinville · 2018-01-24T19:22:07Z

CHANGELOG.md

@@ -1 +1,110 @@
 # Changelog
+
+Items starting with `DEPRECATE` are important deprecation notices. For more
+information on the list of deprecated flags and APIs have a look at


Sorry to be picky but we need a comma after APIs.

andrewhsu · 2018-01-24T21:21:47Z

CHANGELOG.md

+### ---Triage---
+
+- fix Daemon.cleanupMetricsPlugins() [moby/moby#36036](https://github.com/moby/moby/pull/36036)
+* Honor DOCKER_RAMDISK with containerd 1.0 [moby/moby#35957](https://github.com/moby/moby/pull/35957)


i think this can go to the Runtime section

vieux · 2018-01-24T21:50:27Z

CHANGELOG.md

+### Builder
+
+* Install-containerd-static: use netgo buildtag [moby/moby#35753](https://github.com/moby/moby/pull/35753)
+ Add dockerfile for building on non-amd64 platforms [docker/cli#816](https://github.com/docker/cli/pull/816)


I would either remove it or move it to client, it's not really related to the builder

vieux · 2018-01-24T21:50:50Z

CHANGELOG.md

+* Improve zfs init log message for zfs [moby/moby#36033](https://github.com/moby/moby/pull/36033)
+* Wrap response error for container logs method. [moby/moby#36000](https://github.com/moby/moby/pull/36000)
+ Add journald tag as SYSLOG_IDENTIFIER [moby/moby#35570](https://github.com/moby/moby/pull/35570)
+


vieux · 2018-01-24T21:51:38Z

CHANGELOG.md

+
+* Carry #34248 Added tag log option to json-logger and use RawAttrs [moby/moby#35949](https://github.com/moby/moby/pull/35949)
+* Improve daemon config reload; log active configuration [moby/moby#36019](https://github.com/moby/moby/pull/36019)
+* Improve zfs init log message for zfs [moby/moby#36033](https://github.com/moby/moby/pull/36033)


I'd put it in runtime, lot related to the logging functionality of docker.

vieux · 2018-01-24T21:51:49Z

CHANGELOG.md

+
+### Logging
+
+* Carry #34248 Added tag log option to json-logger and use RawAttrs [moby/moby#35949](https://github.com/moby/moby/pull/35949)


remove "Carry #34248"

vieux · 2018-01-24T21:52:13Z

CHANGELOG.md

+* Vendor Microsoft/hcsshim @ v0.6.8 [moby/moby#35924](https://github.com/moby/moby/pull/35924)
+* Windows: Bump RW layer size [moby/moby#35925](https://github.com/moby/moby/pull/35925)
+* Carry #35333: Devicemapper: ignore Nodata errors when delete thin device [moby/moby#35919](https://github.com/moby/moby/pull/35919)
+* Closes #35702 introduce « exec_die » event [moby/moby#35744](https://github.com/moby/moby/pull/35744)


remove "Closed #35702"

thaJeztah

left comments inline

thaJeztah · 2018-01-24T22:38:04Z

CHANGELOG.md

-* Golint and Ineffassign  fixes [moby/moby#36011](https://github.com/moby/moby/pull/36011)
-* Golint: remove redundant ifs [docker/cli#807](https://github.com/docker/cli/pull/807)
-* Gometalinter: fix --deadline option [moby/moby#36035](https://github.com/moby/moby/pull/36035)
-* Bump containerd to 1.0.1 (9b55aab90508bd389d7654c4baf173a981477d55) [moby/moby#35986](https://github.com/moby/moby/pull/35986)


This looks like something we should mention

thaJeztah · 2018-01-24T22:39:28Z

CHANGELOG.md

-* Bump version to v18.02.0-dev [docker/cli#793](https://github.com/docker/cli/pull/793)
-* Update gotestyourself vendor [moby/moby#36034](https://github.com/moby/moby/pull/36034)
- Fix node-generic-resources CLI typo [moby/moby#35970](https://github.com/moby/moby/pull/35970)
-* Improve presentation of published port ranges [docker/cli#581](https://github.com/docker/cli/pull/581)


This is something we need (people (should not, but) may be parsing the output of docker ps)

thaJeztah · 2018-01-24T22:41:15Z

CHANGELOG.md

-* Small nitpick: create ErrVolumeTargetIsRoot in the volume package [moby/moby#36009](https://github.com/moby/moby/pull/36009)
-+ Add helpers to create errdef errors [moby/moby#35638](https://github.com/moby/moby/pull/35638) (code refactoring)
-
-* Bump libnetwork to a1dfea384b39779552a3b4837ea9303194950976 [moby/moby#35976](https://github.com/moby/moby/pull/35976)


all changes were now mentioned separate? moby/moby#35976 (comment)

Did mention everything under Changes included did not include what was found under other changes:

Namely:

docker/libnetwork#2047 Remove watchMiss for swarm mode docker/libnetwork#2042 enable unit test in arm64

thaJeztah · 2018-01-24T22:41:51Z

CHANGELOG.md

@@ -1 +1,67 @@
 # Changelog
+
+Items starting with `DEPRECATE` are important deprecation notices. For more


I think we no longer use this convention, we should consider removing this

Does anyone else want to weigh in on whether this should be removed?

@vieux , @andrewhsu , @seemethere , @mistyhacks ?

Removing the first sentence

thaJeztah · 2018-01-24T22:42:45Z

CHANGELOG.md

+
+### Builder
+
+* Install-containerd-static: use netgo buildtag [moby/moby#35753](https://github.com/moby/moby/pull/35753)


We can probably remove this one; it's about a compile-time flag for building containerd

thaJeztah · 2018-01-24T23:08:13Z

CHANGELOG.md

+* Introduce « exec_die » event [moby/moby#35744](https://github.com/moby/moby/pull/35744)
+* Ensure CPU quota/period updates are sent to runc [moby/moby#36030](https://github.com/moby/moby/pull/36030)
+* Make container shm parent unbindable [moby/moby#35830](https://github.com/moby/moby/pull/35830)
+* Make image (layer) downloads faster by using pigz [moby/moby#35697](https://github.com/moby/moby/pull/35697)


This is a feature/enhancement

~~How should I deal with this?~~
~~Should I place it under a feature or enhancement section?~~

Edit: Adding a + to the features!

@jose-bigio yes, just + sign

thaJeztah · 2018-01-24T23:09:12Z

CHANGELOG.md

+* Ensure CPU quota/period updates are sent to runc [moby/moby#36030](https://github.com/moby/moby/pull/36030)
+* Make container shm parent unbindable [moby/moby#35830](https://github.com/moby/moby/pull/35830)
+* Make image (layer) downloads faster by using pigz [moby/moby#35697](https://github.com/moby/moby/pull/35697)
+ Add timeouts for volume plugin ops [moby/moby#35441](https://github.com/moby/moby/pull/35441)


"Protect the daemon from volume plugins that are slow or deadlocked"

thaJeztah · 2018-01-24T23:09:23Z

CHANGELOG.md

+* Make container shm parent unbindable [moby/moby#35830](https://github.com/moby/moby/pull/35830)
+* Make image (layer) downloads faster by using pigz [moby/moby#35697](https://github.com/moby/moby/pull/35697)
+ Add timeouts for volume plugin ops [moby/moby#35441](https://github.com/moby/moby/pull/35441)
+* Upgrade the frozen images to multi-arch ones [moby/moby#35929](https://github.com/moby/moby/pull/35929)


We can remove this one

thaJeztah · 2018-01-24T23:09:58Z

CHANGELOG.md

+* Make image (layer) downloads faster by using pigz [moby/moby#35697](https://github.com/moby/moby/pull/35697)
+ Add timeouts for volume plugin ops [moby/moby#35441](https://github.com/moby/moby/pull/35441)
+* Upgrade the frozen images to multi-arch ones [moby/moby#35929](https://github.com/moby/moby/pull/35929)
+* Honor DOCKER_RAMDISK with containerd 1.0 [moby/moby#35957](https://github.com/moby/moby/pull/35957)


"Fix DOCKER_RAMDISK environment variable not being honoured" (or similar)

thaJeztah · 2018-01-24T23:10:25Z

CHANGELOG.md

+ Add timeouts for volume plugin ops [moby/moby#35441](https://github.com/moby/moby/pull/35441)
+* Upgrade the frozen images to multi-arch ones [moby/moby#35929](https://github.com/moby/moby/pull/35929)
+* Honor DOCKER_RAMDISK with containerd 1.0 [moby/moby#35957](https://github.com/moby/moby/pull/35957)
+* Improve zfs init log message for zfs [moby/moby#36033](https://github.com/moby/moby/pull/36033)


You can remove this one

seemethere · 2018-01-24T23:39:39Z

We should also add something for the packaging section:

* Added packaging for Fedora 26, Fedora 27, and Centos 7 on aarch64

thaJeztah

One more we should add: moby/moby#36097

And can you squash your commits if everyone is ok with this version for rc1?

LGTM with those changes (we can address nits and improvements in a follow-up rc)

Signed-off-by: jose-bigio <jose.bigio@docker.com>

seemethere

LGTM

remove fedora 28 because it is eol Upstream-commit: 4166725 Component: packaging

…gesSaveAndLoad_on_RS1 [18.09 backport] integration-cli: Skip TestAPIImagesSaveAndLoad on RS3 and older Upstream-commit: a71dd0878516b1a06b7f7ad183980a92bf5dca19 Component: engine

remove fedora 28 because it is eol

andrewhsu requested review from thaJeztah, vieux, mdlinville and gbarr01 January 24, 2018 17:21

andrewhsu reviewed Jan 24, 2018

View reviewed changes

jose-bigio force-pushed the 18.02_changelog branch 2 times, most recently from 58e2de9 to 0816a4b Compare January 24, 2018 17:26

mdlinville suggested changes Jan 24, 2018

View reviewed changes

andrewhsu added this to the 18.02.0 milestone Jan 24, 2018

jose-bigio force-pushed the 18.02_changelog branch from 0816a4b to 72a23f1 Compare January 24, 2018 19:02

mdlinville approved these changes Jan 24, 2018

View reviewed changes

jose-bigio mentioned this pull request Jan 24, 2018

Changed the wording on some of the template vieux/docker-changelog#1

Closed

jose-bigio changed the base branch from master to 18.02 January 24, 2018 21:08

seemethere changed the title ~~[WIP] [18.02] Create 18.02 Changelog~~ [18.02] Create 18.02 Changelog Jan 24, 2018

andrewhsu reviewed Jan 24, 2018

View reviewed changes

jose-bigio force-pushed the 18.02_changelog branch from 72a23f1 to 20bb81a Compare January 24, 2018 21:24

vieux reviewed Jan 24, 2018

View reviewed changes

jose-bigio force-pushed the 18.02_changelog branch from 765bb93 to 3e0a41c Compare January 24, 2018 23:04

thaJeztah suggested changes Jan 24, 2018

View reviewed changes

jose-bigio force-pushed the 18.02_changelog branch 2 times, most recently from ea03a11 to e9718b5 Compare January 25, 2018 00:14

thaJeztah approved these changes Jan 25, 2018

View reviewed changes

jose-bigio force-pushed the 18.02_changelog branch from e9718b5 to ba53952 Compare January 25, 2018 00:27

Create 18.02 Changelog

1dcf665

Signed-off-by: jose-bigio <jose.bigio@docker.com>

jose-bigio force-pushed the 18.02_changelog branch from ba53952 to 1dcf665 Compare January 25, 2018 00:28

seemethere approved these changes Jan 25, 2018

View reviewed changes

seemethere merged commit f903039 into docker-archive:18.02 Jan 25, 2018

docker-jenkins pushed a commit that referenced this pull request Oct 15, 2019

Merge pull request #394 from andrewhsu/rm28

7d6240f

remove fedora 28 because it is eol Upstream-commit: 4166725 Component: packaging

akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023

Merge pull request docker-archive#394 from andrewhsu/rm28

4166725

remove fedora 28 because it is eol


		### Logging

		* Carry #34248 Added tag log option to json-logger and use RawAttrs [moby/moby#35949](https://github.com/moby/moby/pull/35949)

		@@ -1 +1,67 @@
		# Changelog

		Items starting with `DEPRECATE` are important deprecation notices. For more


		### Builder

		* Install-containerd-static: use netgo buildtag [moby/moby#35753](https://github.com/moby/moby/pull/35753)

[18.02] Create 18.02 Changelog #394

[18.02] Create 18.02 Changelog #394

Conversation

jose-bigio commented Jan 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jose-bigio Jan 24, 2018 • edited Loading

Choose a reason for hiding this comment

jose-bigio commented Jan 24, 2018

mdlinville left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thaJeztah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jose-bigio Jan 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seemethere commented Jan 24, 2018 • edited Loading

thaJeztah left a comment

Choose a reason for hiding this comment

seemethere left a comment

Choose a reason for hiding this comment

jose-bigio commented Jan 24, 2018 •

edited

Loading

jose-bigio Jan 24, 2018 •

edited

Loading

jose-bigio Jan 24, 2018 •

edited

Loading

seemethere commented Jan 24, 2018 •

edited

Loading