Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.02] Using Flags instead of PersistentFlags, as Kubernetes flags seem not … #410

Merged
merged 1 commit into from
Jan 31, 2018
Merged

[18.02] Using Flags instead of PersistentFlags, as Kubernetes flags seem not … #410

merged 1 commit into from
Jan 31, 2018

Conversation

andrewhsu
Copy link
Contributor

backport:

with cherry-pick of git commit docker/cli@14fcadf:

$ git cherry-pick -s -x -Xsubtree=component/cli 14fcadf

no conflicts

@silvin-lubecki @andrewhsu
Using Flags instead of PersistentFlags, as Kubernetes flags seem not …
65553aa 
…to be defined in the "persistent space".

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
(cherry picked from commit 14fcadffb137eb673f66669c3f30d7e289553d69)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu added this to the 18.02.0 milestone Jan 31, 2018
vdemeester
vdemeester approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@andrewhsu andrewhsu merged commit bbc43ec into docker-archive:18.02 Jan 31, 2018
@andrewhsu andrewhsu deleted the fix2 branch January 31, 2018 22:44
docker-jenkins pushed a commit that referenced this pull request Oct 28, 2019
@andrewhsu
Merge pull request #410 from thaJeztah/19.03_backport_fix_buildkit_pr…
b0d190a 
…unegc_filter_config

[19.03 backport] daemon/config: fix filter type in BuildKit GC config
Upstream-commit: e2e3abec71f30e533a01e8f1f9669e55b1361fc1
Component: engine
docker-jenkins pushed a commit that referenced this pull request Nov 28, 2019
RHEL8 iptables build fix (#410)
0c8d815 
add optional requirement for nftables on RHEL8+ derivatives
Upstream-commit: cfc7f43d3ed851510b3cd994145a322499aa3767
Component: packaging
docker-jenkins pushed a commit that referenced this pull request May 1, 2020
@thaJeztah
RHEL8 iptables build fix (#410)
6fd5125 
add optional requirement for nftables on RHEL8+ derivatives

(cherry picked from commit cfc7f43d3ed851510b3cd994145a322499aa3767)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 836237c
Component: packaging
docker-jenkins pushed a commit that referenced this pull request May 1, 2020
@tiborvass
Merge pull request #463 from thaJeztah/master_rhel_iptables
a8149ff 
[master] RHEL8 iptables build fix (#410)
Upstream-commit: c14f002
Component: packaging
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
@thaJeztah
RHEL8 iptables build fix (docker-archive#410)
836237c 
add optional requirement for nftables on RHEL8+ derivatives

(cherry picked from commit cfc7f43d3ed851510b3cd994145a322499aa3767)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
@tiborvass
Merge pull request docker-archive#463 from thaJeztah/master_rhel_ipta…
c14f002 
…bles

[master] RHEL8 iptables build fix (docker-archive#410)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.02.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewhsu @vdemeester @silvin-lubecki