-
Notifications
You must be signed in to change notification settings - Fork 879
Conversation
e6967e5
to
c7496dc
Compare
Assuming you like this, how do we get flake8 to ignore the setup.py in the extension's folder, or do I just need to fix the file to pass the style tests? |
I haven't actually gone over the implementation yet, but I'd drop the |
@ncdc re: flake, tweak this: https://github.com/docker/docker-registry/blob/master/tox.ini#L6 |
1211a16
to
752e973
Compare
Guys, like I said, I'm happy with the community owning extensions. So give me a ping when:
and I'll merge (eg: don't wait for a review from me on these). |
name = "refcount-docker-registry-extension", | ||
version = "0.1", | ||
description = "Refcount Docker Registry Extension", | ||
long_description = open('../../README.md').read(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a separate README and LICENSE for the extension.
Add refcount extension to store image references and cleanup orphans. Based heavily on @wking's work in docker-archive#409 - this is just an adaptation to extension format. Signed-off-by: Andy Goldstein <agoldste@redhat.com>
752e973
to
4e5f2e9
Compare
@wking I added a license and readme for the extension. Also, I changed the |
1 other thing - how would you write tests for this? |
On Tue, Dec 02, 2014 at 02:30:34PM -0800, Olivier Gambier wrote: Do we care about supporting this for the Python registry? Folks have |
@wking Is there a timeline for the go rewrite? I had not even heard about it until now. Just curious. |
On Tue, Dec 02, 2014 at 05:19:54PM -0800, Matt Hughes wrote:
Alpha is due 2014-11-24, and the first RC is due 2015-01-12 1. |
@wking I'm happy with it either way. |
@dmp42 we're ok closing this as long as the v2 registry supports pruning/gc in some fashion (either directly or via an extension) |
I believe v2 will support pruning / gc, either in core or an extension. |
Add refcount extension to store image references and cleanup orphans.
Based heavily on @wking's work in
#409 - this is just an
adaptation to extension format.
Signed-off-by: Andy Goldstein agoldste@redhat.com