Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.09 backport] Ignore xattr ENOTSUP errors on copy (fixes #38155) #135

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 12, 2018

backport of moby#38316 for 18.09
fixes moby#38155 for 18.09

git checkout -b 18.09_backport_xattr_fix ce-engine/18.09    
git cherry-pick -s -S -x d0192ae154e6244edd4bf1bb298ea24146378058

cherry-pick was clean; no conflicts

full diff for the continuity bump; containerd/continuity@bd77b46...004b464

@thaJeztah thaJeztah added this to the 18.09.1 milestone Dec 12, 2018
@thaJeztah
Copy link
Member Author

Janky failure is unrelated (no idea why it's actually regenerating the swagger);

The result of hack/generate-swagger-api.sh differs

Copy link

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah force-pushed the 18.09_backport_xattr_fix branch from 973caae to b076df6 Compare January 8, 2019 10:42
@thaJeztah
Copy link
Member Author

rebased to trigger CI (CI results were purged)

@thaJeztah thaJeztah modified the milestones: 18.09.1, 18.09.2 Jan 24, 2019
@dmandalidis
Copy link

Hi, is this going to finally reach 18.09.2? (last activity was a long time ago)

Signed-off-by: Dimitris Mandalidis <dimitris.mandalidis@gmail.com>
(cherry picked from commit d0192ae)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 18.09_backport_xattr_fix branch from b076df6 to c51d247 Compare February 9, 2019 10:04
@thaJeztah thaJeztah modified the milestones: 18.09.2, 18.09.3 Feb 11, 2019
@tiborvass tiborvass merged commit db7a8cb into docker-archive:18.09 Feb 21, 2019
@thaJeztah thaJeztah deleted the 18.09_backport_xattr_fix branch February 21, 2019 23:00
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Mar 12, 2019
https://github.com/docker/docker-ce/releases/tag/v18.09.3

The more important fixes in this version:
* When copying existing folder, ignore xattr set errors when the target filesystem doesn't support xattr. docker-archive/engine#135
* Graphdriver: fix device mode not being detected if character-device bit is set. docker-archive/engine#160
* Fix nil pointer derefence on failure to connect to containerd. docker-archive/engine#162
* Delete stale containerd object on start failure. docker-archive/engine#154
liske pushed a commit to liske/aports that referenced this pull request Apr 7, 2019
https://github.com/docker/docker-ce/releases/tag/v18.09.3

The more important fixes in this version:
* When copying existing folder, ignore xattr set errors when the target filesystem doesn't support xattr. docker-archive/engine#135
* Graphdriver: fix device mode not being detected if character-device bit is set. docker-archive/engine#160
* Fix nil pointer derefence on failure to connect to containerd. docker-archive/engine#162
* Delete stale containerd object on start failure. docker-archive/engine#154
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants