This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] daemon: Use short libnetwork ID in exec-root & update libnetwork #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marked as WIP because this vendors from my fork, pending moby/libnetwork#2482 to be merged |
also updates libnetwork to d9a6682a4dbb13b1f0d8216c425fe9ae010a0f23 full diff: moby/libnetwork@3eb3938...d9a6682 - moby/libnetwork#2482 [19.03 backport] Shorten controller ID in exec-root to not hit UNIX_PATH_MAX - moby/libnetwork#2483 [19.03 backport] Fix panic in drivers/overlay/encryption.go Signed-off-by: Grant Millar <rid@cylo.io> (cherry picked from commit df7b8f4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
19.03_backport_39608_short_libnetwork_id
branch
from
d7d05ba
to
d3d724e
Compare
thaJeztah
changed the title
|
libnetwork PRs were merged, so removed "WIP" |
|
Is this a known flake? |
|
hm; not sure actually if it's a known one |
|
@thaJeztah just checking if this can be merged? Thanks! |
tonistiigi
approved these changes
Jan 16, 2020
|
merging this if it goes green @arkodg can you do a follow up with the latest of the 19.03 branch from libnetwork? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of:
Relates to / addresses: moby#39608 Upgrade to 19.03 from 18 results in libnetwork-setkey hitting UNIX_PATH_MAX limit