This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] Windows: Start of enabling tests under integration #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm.. looks like we need a vendor or vendor bump somewhere; |
|
right; that import was added in moby#37701 (moby@14da20f#diff-204a9536b52c895f8a02e75d2e00dd16R21), which cannot be included in this PR, so I'll add that import manually |
- Add windows CI entrypoint script. Signed-off-by: John Howard <jhoward@microsoft.com> Signed-off-by: Vincent Demeester <vincent@sbr.pm> Signed-off-by: Daniel Nephin <dnephin@docker.com> Signed-off-by: Vincent Demeester <vincent@sbr.pm> (cherry picked from commit d3cc071) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Salahuddin Khan <salah@docker.com> (cherry picked from commit 4c8b1fd) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Deep Debroy <ddebroy@docker.com> (cherry picked from commit 7d1c1a4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
18.09_backport_windows_enable_integration
branch
from
d1ce4fb
to
9fc9c30
Compare
thaJeztah
commented
Nov 8, 2018
| @@ -17,6 +17,7 @@ import ( | |||
| "gotest.tools/assert" | |||
| is "gotest.tools/assert/cmp" | |||
| "gotest.tools/poll" | |||
| "gotest.tools/skip" | |||
There was a problem hiding this comment.
added the missing import
This was referenced Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of moby#37715 for the 18.09 branch
cherry-pick was clean, no conflicts
Integration tests on Windows.
This was originally @jhowardmsft's work and then vdemeesters and enables the integration tests on windows CI (see moby#36748)
This is also a follow up of moby#35362 — initial description below.
Currently in progress, with a custom job in jenkins.
This change is a requirement for moby#34226.
This change also brings the windowsRS1 build in line with all the other builds, which have an entry point at hack/ci. The windowsRS1 config has been updated to call this script.
This change is important because currently the configuration in jenkins makes too many assumptions about the repo and artifacts created by the build. We need a minimal interface between our CI configuration and the repo, so that we are free to make changes in a PR without requiring complicated acrobatics to support those changes in CI.