Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Change nsinit root to /var/run/nsinit #507

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Change nsinit root to /var/run/nsinit #507

merged 1 commit into from
Apr 3, 2015

Conversation

crosbymichael
Copy link
Contributor

Signed-off-by: Michael Crosby crosbymichael@gmail.com

@crosbymichael
Change nsinit root to /var/run/nsinit
fa9efe8 
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@crosbymichael crosbymichael mentioned this pull request Apr 3, 2015
Merged
@mrunalp
Copy link
Contributor

mrunalp commented Apr 3, 2015

LGTM

crosbymichael added a commit that referenced this pull request Apr 3, 2015
@crosbymichael
Merge pull request #507 from crosbymichael/nsinit-root
346236b 
Change nsinit root to /var/run/nsinit
@crosbymichael crosbymichael merged commit 346236b into docker-archive:master Apr 3, 2015
@crosbymichael crosbymichael deleted the nsinit-root branch April 3, 2015 17:50
@SaiedKazemi
Copy link
Contributor

@crosbymichael @avagin
LGTM. Although now I understand how it works, it's a good idea to change the default value so others won't be confused.
By the way, I think the Checkpoint() and Restore() APIs will be more flexible if the CRIU images directory was passed in. If nil is passed in, it can use filepath.Join(c.root, "checkpoint"). But if it's set to a particular path, that would be the images directory to use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crosbymichael @mrunalp @SaiedKazemi