Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally deprecate the legacy line-based format #45

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

tianon
Copy link
Member

@tianon tianon commented Jun 8, 2022

Closes #16

(This is the real reason behind #44 😂 wanted an easier way to see whether this actually decreases coverage anywhere that matters 👀)

@codecov-commenter
Copy link

Codecov Report

Merging #45 (69f4323) into master (017573e) will decrease coverage by 1.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   78.35%   76.83%   -1.53%     
==========================================
  Files           7        5       -2     
  Lines         670      587      -83     
==========================================
- Hits          525      451      -74     
+ Misses        110      104       -6     
+ Partials       35       32       -3     
Impacted Files Coverage Δ
manifest/rfc2822.go 73.14% <ø> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017573e...69f4323. Read the comment docs.

@tianon
Copy link
Member Author

tianon commented Jun 8, 2022

I've reviewed the "change in coverage" lines from https://app.codecov.io/gh/docker-library/bashbrew/compare/45/changes and they're all reasonable! I think my naive approach to removing this is probably correct. 😄

@tianon
Copy link
Member Author

tianon commented Jun 8, 2022

$ ./bin/bashbrew cat --all > /dev/null
$ 

🎉

(No current manifests use the line-based format thanks to the work in #16)

@yosifkit yosifkit merged commit b4880ac into docker-library:master Jun 9, 2022
@yosifkit yosifkit deleted the single-line branch June 9, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate single line library file format
3 participants