Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting registry mirror via environment variables #236

Closed
wants to merge 1 commit into from

Conversation

Yannik
Copy link

@Yannik Yannik commented May 18, 2020

This enables using registry mirrors in environments where the container command can not be modified.

@tianon
Copy link
Member

tianon commented May 18, 2020

Duplicate of #62.

What environment are you in where you cannot configure the command of the container to be run, but can modify/append environment variables?

@Yannik
Copy link
Author

Yannik commented May 18, 2020

@tianon gitlab with disable_entrypoint_overwrite set.

@tianon
Copy link
Member

tianon commented May 18, 2020

Wouldn't that only block the ability to change entrypoint:, not command:?

@tianon
Copy link
Member

tianon commented Jun 19, 2020

Confirmed via https://gitlab.hzdr.de/fwcc/gitlab-runner/commit/040a84d1050af1f5fd52b46339e2a0d591994a66#7a056729f6a9c4b323621c1ee3ee2894be489989 -- when disable_entrypoint_overwrite is set to true, it blocks the setting of entrypoint:, but not command: (which is IMO very weird, but means this isn't needed since command: is enough to add --registry-mirror). 👍

@tianon tianon closed this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants