-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Re-enable 5.6
for Elastic products
#1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable 5.6
for Elastic products
#1043
Conversation
Seems sane -- do we need to also cc @jasontedor and/or @elasticdog? 😇 (This is of course just a small portion the work to be done to bring these back now -- we've also got to un-archive the repos and re-enable their |
(Threading the needle: #842 is a previously related PR, and the discussion in docker-library/elasticsearch#160 is highly relevant, and was the catalyst for the deprecation in the first place.) |
elasticsearch/deprecated.md
Outdated
@@ -1,3 +1,3 @@ | |||
This image has been deprecated in favor of the [official `elasticsearch` image](https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html) provided and maintained by [elastic.co](https://www.elastic.co/). The upstream images are available to pull via `docker.elastic.co/elasticsearch/elasticsearch:[version]` like `5.4.2`. The images found here will receive no further updates once the `5.6.0` release is available upstream. Please adjust your usage accordingly. | |||
This image has been deprecated in favor of the [official `elasticsearch` image](https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html) provided and maintained by [elastic.co](https://www.elastic.co/). The list of images available from Elastic can be found at www.docker.elastic.co. The images found here will receive no further updates once the `6.0.0` release is available upstream. Please adjust your usage accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This www.docker.elastic.co
reference ought to be a link, ala:
... can be found at [www.docker.elastic.co](https://www.docker.elastic.co/). ...
Also, you don't happen to know a more specific timeline for 6.0, right? (it's helpful to users to note the exact cut-off date, but if it's not possible to know yet, that's obviously fair 😄) |
Yep, this is all good with me... @dliappis is just pushing forward with the plan that we've discussed internally here at Elastic. I believe @skearns64, our Sr. Director of Product Management has also been in contact with someone internally there at Docker regarding the situation (although I'm not sure whom in particular). Assistance on re-enabling the |
Ok, cool; just double-checking! 👍 ❤️ (especially since this is the first / only we've heard of it 😄) I'm happy to go ahead and take over from here; thanks! 👍 (I think we actually need to get the image added back in https://github.com/docker-library/official-images/tree/master/library first, so I'll start there and get the repos de-archived, etc and come back to merge this once all that's in place) |
This reverts commit 618b2fe. See docker-library/docs#1043.
37370e7
to
b24695b
Compare
This reverts commit 6fad642. This does _not_ include the generated `README.md` files -- we'll let @docker-library-bot recreate those.
Migrating existing users of the library images to the Elastic provided ones during a minor release (5.6) is a big potentially breaking change. Extend support for library images through 5.6 as well until 6.0.0 has been released.
Update logo.png for Elasticsearch/Kibana/Logstash
b24695b
to
95d1533
Compare
See docker-library/docs#1043 for more details.
Alllright, got Travis green here, and got the And the Official Images PR to officially restore the images as well: docker-library/official-images#3610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for double checking and for your understanding @tianon.
Migrating existing users of the library images to the Elastic provided
ones during a minor release (
5.6
) is a big, potentially breaking,change. It seems like a safer approach to keep producing images until
6.0.0
is out, so that the community can benefit from bug and security fixesthroughout 5.x and give more time to adjust to the new images.
Extend support for library images through
5.6.x
until6.0.0
hasbeen released. Also update the product logos.
Relates #945