Skip to content

Fixed instructions in Redis container docs #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed instructions in Redis container docs #1486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion redis/content.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ Redis is an open-source, networked, in-memory, key-value data store with optiona
$ docker run --name some-redis -d %%IMAGE%%
```

Connect to it locally on your machine:

```console
$ docker run --name some-redis -p 127.0.0.1:6379:6379 -d %%IMAGE%%
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not suggest this to users, since this is really something that should be easily inferred by someone familiar with Docker and/or how -p works (and we'd prefer to keep the documentation somewhat succinct and specific to Redis instead of a general guide to using Docker).


## start with persistent storage

```console
Expand All @@ -26,10 +32,24 @@ For more about Redis Persistence, see [http://redis.io/topics/persistence](http:

## connecting via `redis-cli`

Create the network first:

```console
$ docker run -it --network some-network --rm %%IMAGE%% redis-cli -h some-redis
$ docker network create some-network
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along similar lines, the docker network create bits were intentionally left out of #1441 (as implied by the title) -- we'd prefer not to document Docker basics here and instead provide more reference/tips for using Redis with this image.


Start the server in the same network, see `--network` argument:

```console
$ docker run --name some-redis --network some-network -d %%IMAGE%%
```

Run the `redis-cli` in a docker container in the same network:

```console
$ docker run -it --network some-network --rm %%IMAGE%% redis-cli -h some-redis
``

## Additionally, If you want to use your own redis.conf ...

You can create your own Dockerfile that adds a redis.conf from the context into /data/, like so.
Expand Down