Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mediawiki docker-compose install instructions #2358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve mediawiki docker-compose install instructions #2358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mediawiki/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ volumes:

Run `docker stack deploy -c stack.yml mediawiki` (or `docker-compose -f stack.yml up`), wait for it to initialize completely, and visit `http://swarm-ip:8080`, `http://localhost:8080`, or `http://host-ip:8080` (as appropriate).

When specifying the database host as part of the wiki setup process, make sure to use `database://localhost`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, localhost wouldn't be correct though, because that would imply the container mediawiki is running in -- rather, that should be something like database://db, right? (This would also need to be part of content.md as README.md is generated, so it might be even better to include it as a code comment inside stack.yml)

Also cc mediawiki image maintainers: @legoktm @addshore @christian-heusel

Copy link
Author

@lectrician1 lectrician1 Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localhost would be correct though because there are separate mediawiki and database services. For the mediawiki container to connect to the database it needs to use the localhost of the database container which the MySQL database is exposing itself to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localhost might work but it's not ideal to leave the compose environment and the name of the service should be used instead (database in this case).


## Adding additional libraries / extensions

This image does not provide any additional PHP extensions or other libraries, even if they are required by popular plugins. There are an infinite number of possible plugins, and they potentially require any extension PHP supports. Including every PHP extension that exists would dramatically increase the image size.
Expand Down