SonarQube rebrand #2511
Merged
SonarQube rebrand #2511
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't mind doing a "squash and merge", but if you really want to squash and force push, that is fine too. There are a couple failing tests that need addressed:
|
davividal
force-pushed
the
sonarqube-community-rebrand
branch
from
331acf9
to
56ac9b3
Compare
davividal
force-pushed
the
sonarqube-community-rebrand
branch
from
56ac9b3
to
db8b475
Compare
|
Thanks for the answer, @yosifkit. I addressed your comments and squashed the commits. |
yosifkit
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are rebranding SonarQube with a new logo, naming, and offerings, we need to update the Docker documentation to properly reflect that.
Can these commits be squashed or must I do that on my side before?