Skip to content

Add HEALTHCHECK instruction #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebuildy opened this issue Feb 2, 2017 · 2 comments
Closed

Add HEALTHCHECK instruction #157

ebuildy opened this issue Feb 2, 2017 · 2 comments

Comments

@ebuildy
Copy link
Contributor

ebuildy commented Feb 2, 2017

HEALTHCHECK instruction (added in Docker 1.12) is very powerful and useful for data-base (because usually other containers will depend on). (more at https://blog.newrelic.com/2016/08/24/docker-health-check-instruction/).

This will tell if elasticsearch is up or not (not the container, but elasticsearch itself).

I think a simple

HEALTHCHECK CMD curl --fail http://localhost:9200/ || exit 1

Could do the trick.

@yosifkit
Copy link
Member

Copying comment from docker-library/cassandra#76 (comment)

I do not feel that generalized healthchecks on the official images are really that useful.

  • users will have their own idea of what is "healthy"
  • it does not actually test that the service is listening to connections outside of localhost (see https://github.com/docker-library/healthcheck for some examples that do more than what's proposed here, including attempting to check whether the service is listening remotely)
    • some of the Official Images even purposely start in a localhost only mode for database initialization and then kill and start the main service with full network availability
  • after upgrading their images, current users will have extra unexpected load on their systems for healthchecks they don't necessarily need/want and may be unaware of

@tianon
Copy link
Member

tianon commented Oct 4, 2017

This image is officially deprecated in favor of upstream's images (see https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html).

For more information, please see #160, docker-library/docs#842, and docker-library/docs#945.

This image has been deprecated in favor of the official elasticsearch image provided and maintained by elastic.co. The upstream images are available to pull via docker.elastic.co/elasticsearch/elasticsearch:[version] like 5.4.2. The images found here will receive no further updates once the 5.6.0 release is available upstream. Please adjust your usage accordingly.

Elastic provides open-source support for Elasticsearch via the elastic/elasticsearch GitHub repository and the Docker image via the elastic/elasticsearch-docker GitHub repository, as well as community support via its forums.

Thanks!

@tianon tianon closed this as completed Oct 4, 2017
1gtm pushed a commit to appscode-images/elasticsearch that referenced this issue Feb 14, 2024
This commit was created by the elastic-dockerfiles-publisher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants