Make the update.sh script MacOSX friendly #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see anything about |
|
Yup you're right everything hasn't been pushed. Sorry |
Original behaviour on Linux is unchanged while making it work on Mac OS X.
| @@ -1,11 +1,19 @@ | |||
| #!/bin/bash | |||
| set -e | |||
|
|
|||
| cd "$(dirname "$(readlink -f "$BASH_SOURCE")")" | |||
| if [[ $(uname) == "Darwin" ]]; then | |||
There was a problem hiding this comment.
This might be better written with single brackets since no pattern matching is being done:
if [ "$(uname)" = 'Darwin' ]; then
|
@yosifkit could you please comment on chance for this PR to get merged? |
|
Since we've moved the |
|
@ggtools with above answer, would it make sense to close this? |
|
Indeed, closing given that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under Mac OSX, the
-fflag will be remove from thereadlinkarguments andsedwill be changed togsed.Behavior under Linux is unchanged.