Issue #5 make elastisearch run as a normal user. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| COPY docker-entrypoint.sh / | ||
|
|
||
| ENTRYPOINT ["/docker-entrypoint.sh"] |
There was a problem hiding this comment.
I'd prefer to see there still be a CMD ["elasticsearch"] here to make it clear what the default command is without having to look at the entrypoint script.
There was a problem hiding this comment.
Yes that makes sense
|
LGTM |
| && gpg --verify /usr/local/bin/gosu.asc \ | ||
| && rm /usr/local/bin/gosu.asc \ | ||
| && chmod +x /usr/local/bin/gosu \ | ||
| && apt-get purge -y --auto-remove curl |
There was a problem hiding this comment.
java:7-jre already has curl installed from buildpack-deps:curl, so we can just use it 😄. Otherwise, this all looks great. Thanks!
- Add a docker-entrypoint.sh script dropping root privileges when starting up elasticsearch. The script uses `gosu` to drop the permission - Add `ENTRYPOINT`, while keeping `CMD` for clarity - Fix `update.sh` script to work with the new elastic.co site Most update is shamelessly borrowed from PostgreSQL official image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting up elasticsearch. The script uses
gosuto drop thepermission
CMDbyENTRYPOINTupdate.shscript to work with the new elastic.co siteMost update is shamelessly borrowed from PostgreSQL official image