Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang:1-alpine image no longer has git #346

Closed
klmitch opened this issue Oct 27, 2020 · 2 comments
Closed

golang:1-alpine image no longer has git #346

klmitch opened this issue Oct 27, 2020 · 2 comments

Comments

@klmitch
Copy link

klmitch commented Oct 27, 2020

It appears that an upstream change to the alpine container has caused git to no longer come pre-installed. This has broken go within the golang:1-alpine image, as it uses git to implement go get, and presumably other commands. The Dockerfile-alpine.template should be updated to ensure git is installed.
klmitch added a commit to klmitch/golang that referenced this issue Oct 27, 2020
@klmitch
Ensure git is installed in alpine image
a9cdea9 
Apparently, a recent update to the upstream alpine image has resulted in
git no longer being installed by default in the alpine container image.
This commit ensures that git is installed.

Closes issue docker-library#346
@klmitch klmitch mentioned this issue Oct 27, 2020
Closed
@tianon
Copy link
Member

tianon commented Oct 27, 2020

I'm not sure where you're seeing that Alpine used to include git by default? Our golang:alpine image has never included git, and that's intentional (#250 (comment); #119, #140, #153, #157, #166, #198, #209, #230, #239, #241, #251, #328).

@tianon
Copy link
Member

tianon commented Oct 27, 2020

#347 (comment) 👍

(Closing in favor of the discussion on #345)

@tianon tianon closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tianon @klmitch