New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no-pic patch #121

Closed

weixiaowilliam wants to merge 1 commit into docker-library:master from weixiaowilliam:fix

Contributor

weixiaowilliam commented Dec 1, 2016

For two reasons:

Alpine has fixed the issue (http://git.alpinelinux.org/cgit/aports/tree/community/go/default-buildmode-pie.patch)
The patch doesn't work for some platforms where Golang adopts external linker (cmd/go: default buildmode incompatible to external linker with PIE enabled by default golang/go#17847). Although Golang developers has fixed the issue with disabling PIE, above Alpine solution is more secure

So, Alpine Go (installed by apk) is better choice.


          Remove no-pic patch

e25c671

For two reasons:
1) Alpine has fixed the issue (http://git.alpinelinux.org/cgit/aports/tree/community/go/default-buildmode-pie.patch)
2) The patch doesn't work for some platforms where Golang adopts external linker (golang/go#17847). Although Golang developers has fixed the issue with disabling PIE, above Alpine solution is more secure

So, Alpine Go (installed by apk) is better choice.

weixiaowilliam closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet