Skip to content

Move oci-import (and SBOM) shell code out of meta.jq into an explicit shell script #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tianon
Copy link
Member

@tianon tianon commented Apr 25, 2025

Also, add a lot more validation.

This new script/code assumes we're setting BASHBREW_META_SCRIPTS to an appropriate value (pointing to the directory of this repository on-disk).

tianon added 2 commits April 11, 2025 16:22
…icit shell script

Also, add a *lot* more validation.

This new script/code assumes we're setting `BASHBREW_META_SCRIPTS` to an appropriate value (pointing to the directory of this repository on-disk).
@tianon tianon requested a review from a team as a code owner April 25, 2025 23:28
@tianon
Copy link
Member Author

tianon commented Apr 25, 2025

(I made tianon/dockerfiles#982 so I could actually test this in a real load-bearing way)

@tianon
Copy link
Member Author

tianon commented Apr 25, 2025

I made this as two separate commits so that the delta between the output of the old "oci-import" builder and the new "oci-import" builder can be plainly and clearly seen in the second commit (because I added a test all by itself in the first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant