Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate more images to the new build system #78

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

LaurentGoderre
Copy link
Member

@LaurentGoderre LaurentGoderre commented Sep 10, 2024

Depends on:

Copy link
Collaborator

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draft…

@@ -5,34 +5,29 @@ def repos_anti_subset:
[
# as we remove items from this list, we need to be careful that none of their *children* are still in the list
# (which is why this is sorted in rough "build order" -- that means we can ~safely "pop" off the bottom)
"clearlinux",
"couchbase",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move these up?

"buildpack-deps", # direct children: erlang gcc golang haskell haxe influxdb kapacitor node openjdk perl pypy python rakudo-star ruby rust telegraf
"couchbase",

"debian", # direct children: aerospike buildpack-deps chronograf clojure couchdb dart emqx erlang haproxy haskell hitch httpd influxdb irssi julia maven memcached mono mysql neo4j neurodebian nginx node odoo openjdk perl php postgres pypy python r-base redis rethinkdb rocket.chat ruby rust spiped swipl unit varnish
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an intent to the reordering?

@LaurentGoderre
Copy link
Member Author

The intent of the reorder is to make the dependencies a bit more clear

@yosifkit
Copy link
Member

Because it was a little hard for me to follow what was moved around in repos_anti_subset vs what was added to the new build system, so I did some quick jq to compare the list before and after:

$ jq -n -L . 'include "doi"; include "doi-new"; repos_anti_subset - new_repos_anti_subset'
[
  "ubuntu",
  "buildpack-deps",
  "eclipse-temurin",
  "haskell",
  "liquibase",
  "rakudo-star",
  "silverpeas"
]

So, these will be the additions to the new build system. This seems fine to me once you are ready. 👍

@gdams
Copy link

gdams commented Sep 12, 2024

I've had a go at adding rakudo-star here anchore/syft#3224

@gdams
Copy link

gdams commented Oct 14, 2024

@LaurentGoderre how close are you to getting this merged? We've got the next eclipse temurin release soon and were hoping to get a riscv64 image out which this PR should enable for us :)

@LaurentGoderre
Copy link
Member Author

@gdams there should be a new version of Scout Indexer available soon so we can close the loop

@gdams
Copy link

gdams commented Oct 17, 2024

@gdams there should be a new version of Scout Indexer available soon so we can close the loop

That would be great! Thanks so much

@LaurentGoderre LaurentGoderre marked this pull request as ready for review October 18, 2024 20:32
@yosifkit yosifkit merged commit 762cadb into docker-library:main Oct 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants