Skip to content

Add a retry loop to initdb logic (handling the edge cases better) #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2017
Merged

Add a retry loop to initdb logic (handling the edge cases better) #153

merged 1 commit into from
Mar 22, 2017

Conversation

tianon
Copy link
Member

@tianon tianon commented Mar 22, 2017

Fixes #150

Kudos to @yosifkit for the simpler idea of checking whether our mongod process even stays running before we try connecting as a really obvious "bail bail bail right away" indicator. 😇 ❤️

@tianon
Copy link
Member Author

tianon commented Mar 22, 2017

This also re-unifies the scripts across all versions (no more extra if statement in 3.2).

@yosifkit yosifkit merged commit 147d079 into docker-library:master Mar 22, 2017
@yosifkit yosifkit deleted the retry-loop branch March 22, 2017 23:18
tianon added a commit to infosiftr/stackbrew that referenced this pull request Mar 23, 2017
@tianon
Update mongo initdb behavior (minor bugfixes)
51865d0 
See:

- docker-library/mongo#151
- docker-library/mongo#152
- docker-library/mongo#153
@tianon tianon mentioned this pull request Mar 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianon @yosifkit