Adjust "ADDLOCAL" to disable the Windows service #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
commented
Nov 30, 2020
Also, update Dockerfile to provide installer logs when the installer fails in an obvious way.
tianon
force-pushed
the
disable-windows-service
branch
from
b9687dd to
69ff4ee
Compare
tianon
commented
Nov 30, 2020
| 'INSTALLLOCATION=C:\mongodb', \ | ||
| 'ADDLOCAL=all' \ | ||
| 'ADDLOCAL=ServerNoService,Client,Router,MiscellaneousTools' \ |
There was a problem hiding this comment.
As a TODO for later, we should probably consider installing the "tools" / "shell" in 4.4+ (now that they're all separate), like we do in the Linux images.
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 2, 2020
Changes: - docker-library/mongo@1d8e0f6: Merge pull request docker-library/mongo#438 from infosiftr/disable-windows-service - docker-library/mongo@69ff4ee: Adjust "ADDLOCAL" to disable the Windows service
|
It turns out this was also making our layer much larger, presumably because it was starting the MongoDB service, which would then initialize the default data directory, and probably decided that preallocating the database files was going to be "faster", so our "install MongoDB" layer from this change went from ~1.99GB down to ~804MB! 🥂 😇 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426