Skip to content

Fix behavior during initialization timeout #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fpytloun
Copy link

Add configurable timeout for MySQL start during initialization. On timeout, remove datadir to allow new initialization try on next container creation. Otherwise mysql will end up in empty unconfigured state without root password set, etc.

Better fix for: #159

@fpytloun fpytloun force-pushed the timeout branch 3 times, most recently from c3c29b7 to fbf03a9 Compare April 28, 2017 11:55
@akerouanton
Copy link

@tianon @yosifkit sorry to ping you directly, but is there any chance this PR got merged sooner or later, or is there any specific issue that should be addressed first?

I'm actually facing failing MySQL init process due to "big" innodb_log_file_size value and I really would like to increase timeout delay rather than decrease that config value.

@yosifkit
Copy link
Member

Sorry for the long tail. 🙇‍♂️

Making the timeout configurable could be useful. Though should probably be addressed after or in #471.

Even though it is currently gated by only running on an empty directory (well, partly-initialized), I would rather not have the rm -rf $DATADIR/mysql. With the possible changes in #471, the temporary localhost-only server could be started without it being a new database; which means a slow start would delete the data.

@yosifkit
Copy link
Member

yosifkit commented Mar 4, 2020

Apologies for the delay 🙇‍♂️

Closing in favor of #646

@yosifkit yosifkit closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants