Created php-zendserver

[dror-g]

php-zendserver is the latest version of Zend Technologies "Zend Server 7" Docker implementation.
It includes many improvements and added features compared to the previous version- zend-php.

[tianon]

Why the name change? What was wrong with zend-php?

[tianon]

Also, I'm not sure it's entirely obvious from the tags that this is Zend Server 7.0. What happens when 7.1 or 8.0 comes out? Do all the tags just update universally, and there's no option for previous stuff? Are the previous versions even supported upstream?

[ziniman]

Regarding the name change - this is our naming convention with all Zend Server integrations out there (see AWS, Openshift, etc.) and we wanted to make sure the Docker repo follows the same convention.

What do you suggest regarding the tags? Add Zend Server 7.0 specifically?

[tianon]

On the naming, it's not trivial to rename an image, and shouldn't be done lightly, so I want to make absolutely sure this is the final name you want this image to be before we merge and do the work to get it switched. Also, in the process, we'll probably lose any download metrics the old image might have had, since for all intents and purposes this will be a new image. Docker itself also has no way to notify users of the current images that there's been a change, so even just for the user experience, this is not something we want to do often. I don't mean to be rude (so I'm very sorry if I'm coming across that way), I just want to make sure you have all the information you need to make an informed choice. 💭

For the tags, I'm thinking something simple like:

@@ -1,7 +1,9 @@
 # maintainer: Dror Gensler <dror.g@zend.com> (@dror-g)

 5.5: git://github.com/zendtech/php-zendserver@c4a4d21b3043d9c3e32a5edcbcd6b628f6a49266 5.5
+5.5-zend7.0: git://github.com/zendtech/php-zendserver@c4a4d21b3043d9c3e32a5edcbcd6b628f6a49266 5.5

 5.4: git://github.com/zendtech/php-zendserver@c4a4d21b3043d9c3e32a5edcbcd6b628f6a49266 5.4
+5.4-zend7.0: git://github.com/zendtech/php-zendserver@c4a4d21b3043d9c3e32a5edcbcd6b628f6a49266 5.4

 latest: git://github.com/zendtech/php-zendserver@c4a4d21b3043d9c3e32a5edcbcd6b628f6a49266 5.5

Then, once 7.1 comes out, it's clear that 7.0 is either still supported (by those tags staying), or is no longer supported (by those tags going away and new zend7.1 tags taking their place).

Alternatively (especially since this is effectively a new image so we can discard any previous convention), you could go with php-zendserver:7.0-php5.4 style instead, which emphasizes the Zend Server version instead of the PHP version, but it all depends on what's more common to want to be specific about for Zend Server users. I would imagine that they'd probably want to be more specific about the version of PHP, but I don't know your users anywhere near as well as you do. 😄

As a final thought, are you, @ziniman, and @dror-g going to be co-maintaining, or are you just coming in to help field questions? If it's the former, I'd love to have two # maintainer: lines to make it clear (see golang for an example). 😄

[dror-g]

Hi Tianon,

We went ahead and implemented the version tags you suggested (php-zendserver:7.0-php5.4 for example).
I will remain the maintainer of this image.
Thanks you!

[tianon]

LGTM

[yosifkit]

I have one comment: in your dockerfile you install zend-server-php-5.5, it would be better if you pin to a specific version so that if their is a rebuild of Ubuntu (like a CVE) we don't get Zend Server upgrading to 7.1 when it is still tagged as 7.0. A current example of version pinning is docker-library/postgres. Just a thought so the rebuilds are deterministic.

[dror-g]

That is an excellent point Yosifkit.
Luckily our repo's are organised this way by default, and the one we add to sources.list in the Dockerfile is already version locked:
"deb http://repos.zend.com/zend-server/7.0/deb_apache2.4 server non-free "

[dror-g]

Please let me know as soon as possible if there's anything else that needs fixing, so I may tend to it before the week is out.

[yosifkit]

Awesome, that works well. I'll run a test build and then we can merge.

[ziniman]

Great! As you might know, we want to announce this next week at ZendCon and for that we need both the official docs and the repos up to date. Will really appreciate a day or two for final testing in the final location so it will be nice to get it merged today.

Thanks for all your help!

[yosifkit]

That sounds reasonable. @tianon and I will do a review on the docs PR.

[yosifkit]

LGTM, ping @tianon for final 👍

$ ./bashbrew/build.sh https://raw.githubusercontent.com/docker-library/official-images/916ec3099491dae8269bdc50f0a410e0e75e6638/library/php-zendserver --namespaces=''Cloning php-zendserver (git://github.com/zendtech/php-zendserver) ...
Processing php-zendserver:5.5 ...
Processing php-zendserver:7.0-php5.5 ...
Processing php-zendserver:7.0 ...
Processing php-zendserver:5.4 ...
Processing php-zendserver:7.0-php5.4 ...
Processing php-zendserver:latest ...

[tianon]

LGTM

[ziniman]

Thanks guys, I see the updated repo. Will give it some additional testing today.
What is the status with the documentation? Our listing on Docker Hub looks a bit poor :-).

[tianon]

Docs status is being tracked at docker-library/docs#78 👍