Skip to content

enable Max Execution Timers for ZTS builds #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Mar 4, 2023

php/php-src#10141 has just been merged. It fixes timeout support for ZTS builds on Linux.
This feature will be enabled by default in PHP 8.3. It hasn't been in previous version because it introduces an ABI break, but it's not a big issue when using the Docker images because the extensions are usually compiled against the local version of PHP. This patch enables this fix.

@dunglas dunglas force-pushed the feat/enable-zend-max-execution-timers branch from ba740fe to 6051a44 Compare March 5, 2023 20:18
@dunglas dunglas marked this pull request as draft March 5, 2023 20:28
@dunglas dunglas force-pushed the feat/enable-zend-max-execution-timers branch from 6051a44 to 8a6546a Compare June 11, 2023 13:56
@dunglas dunglas marked this pull request as ready for review June 11, 2023 13:57
@dunglas
Copy link
Contributor Author

dunglas commented Jun 11, 2023

This PR is now ready to be merged.

Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
@tianon tianon merged commit 6fce78b into docker-library:master Jun 13, 2023
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 13, 2023
Changes:

- docker-library/php@6fce78bd: enable Max Execution Timers for ZTS builds (docker-library/php#1382)
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 13, 2023
Changes:

- docker-library/php@86b8b137: Merge pull request docker-library/php#1416 from infosiftr/bookworm
- docker-library/php@7838b365: Add Debian bookworm, remove buster
- docker-library/php@6fce78bd: enable Max Execution Timers for ZTS builds (docker-library/php#1382)
@dunglas dunglas deleted the feat/enable-zend-max-execution-timers branch June 13, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants