Adjust "docker-php-ext-configure" to also install deps, but have "docker-php-ext-install" remove them if and only if it was "docker-php-ext-*" which installed them. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker-php-ext-install" remove them if and only if it was "docker-php-ext-*" which installed them.
|
Looks great! Very good yet simple optimization |
|
LGTM |
|
Can you run |
|
@tianon I've made your the PR for the run of |
Run update.sh to make the feature available.
|
Thanks 😄 Once Travis is green, we're good to merge! 👍 |
3 tasks
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jun 15, 2016
- `cassandra`: 3.0.7 - `logstash`: fix `PATH` in 5.0.0-alpha3 (docker-library/logstash#50) - `owncloud`: fix failing `pecl install` invocations, remove EOL 7.0 - `php`: fix `docker-php-ext-configure` to install deps if necessary in Alpine (docker-library/php#239) - `pypy`: 3.3-5.2.0-alpha1 and 2-5.3.0 - `rocket.chat`: 0.34.0 - `tomcat`: 8.0.36, 8.5.3, 9.0.0.M8
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237