Remove php src the right way for lightweight containers.

[shouze]

Fixes #234.

• I will call update.sh after the proposed patch have been reviewed.
• I've also included some kind of debian support.

According to @yosifkit #234 (comment) we should obtain that kind of result (uncompressed size container images):

REPOSITORY          TAG                IMAGE ID            CREATED             VIRTUAL SIZE
# current size
php                 alpine             bdae0b0de098        3 days ago          191.5 MB

# sans all source
<none>              <none>             537592e5c872        53 seconds ago      44.3 MB

# keep the php src xz
<none>              <none>             cb1f5c08b4f9        50 minutes ago      55.79 MB

[cjunge]

Should be docker-php-source extract \

[shouze]

@cjunge thx for noticing me the typo... 🙀

[shouze]

ping @tianon @yosifkit any feedback? I can run update.sh if you will.

[yosifkit]

To simplify this I would rather leave the downloading in the Dockerfile and keep the tar.gz file around. This will make the new script only need to do two things, extract and delete. This will also guarantee that any source compiled against in your modules is the same that built the version of php in use and lessen the impact on php servers as well as time on users.

How much time does the extraction and deletion add to a typical docker-php-ext-install? We should probably do some benchmarks beyond size.

This also has ramifications on the docker-php-ext-* scripts since they use /usr/src/php/ext to figure out what extensions are available in their 'usage' sections (see enable, configure, and install). Minimally, we should extract at the start of the file and then delete with logic similar to the apk deletes (configure should not delete, install should delete, and I'm not sure about enable).

[shouze]

@yosifkit ok, will make the changes soon & report numbers about extract/delete times.

[shouze]

ping @yosifkit ok done.

About docker-php-ext-*:

• enable: nothing to do
• configure only extract from tarball if not already done.
• install: extract from tarball if not already done then delete.

The only last possible improvement I see is... if somebody decide in its inherited Dockerfile RUN to call manually at the beginning docker-php-source extract then docker-php-ext-install maybe should not delete everytime at the end and then docker-php-source delete should be explicitly at the end of the Dockerfile RUN.

I will make some benchmark about the extra consumed time by extract process.

[shouze]

@yosifkit benchmark done... on my local machine the extract step is very fast:

time tar -Jxf "/$PHP_FILENAME" -C /usr/src
real    0m 3.10s
user    0m 1.53s
sys 0m 2.48s
time rm -rf /usr/src/php
real    0m 0.52s
user    0m 0.04s
sys 0m 0.48s

I think we can go with this PR as is, I let you review prior to run update.sh & merge it.

[jeremyFreeAgent]

👍

[shouze]

ping @yosifkit @tianon