resolves #282: add default healthcheck to dockerfiles #635
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see an approach using
pg_isready
when browsing through #282 and other proposed changes, but perhaps someone has already been down this route?Probably someone will have input on the actual
HEALTHCHECK
settings to use (e.g.interval
,timeout
,retries
) I can make any requested changes real quick (provided some intentional reason ;)P.S. The readme told me to look over at https://hub.docker.com/_/postgres?tab=description info on contributing, I might be tired and completely overlooking it, but I didn't actually see anything. Hopefully I've set this up correctly, LMK if theres anything at all desired from a contributor perspective.