Skip to content

resolves #282: add default healthcheck to dockerfiles #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zaquestion
Copy link

@zaquestion zaquestion commented Nov 17, 2019

I didn't see an approach using pg_isready when browsing through #282 and other proposed changes, but perhaps someone has already been down this route?

Probably someone will have input on the actual HEALTHCHECK settings to use (e.g. interval, timeout, retries) I can make any requested changes real quick (provided some intentional reason ;)

P.S. The readme told me to look over at https://hub.docker.com/_/postgres?tab=description info on contributing, I might be tired and completely overlooking it, but I didn't actually see anything. Hopefully I've set this up correctly, LMK if theres anything at all desired from a contributor perspective.

@zaquestion
Copy link
Author

The postgres docs (and some 3rd party release notes) seem to imply that this is supported since 9.3, but the docs them self also list 9.3 as incompatible, nevertheless everything in this repos seems to be >=9.4 so seemingly we're good there.

Ref: https://www.postgresql.org/docs/9.3/app-pg-isready.html

@zaquestion
Copy link
Author

Closing per docker-library HEALTHCHECK policy

See: #282 (comment)

Ref: https://github.com/docker-library/faq#healthcheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant